Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup serialization of settings JSON file. NFC #15912

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Cleanup serialization of settings JSON file. NFC #15912

merged 1 commit into from
Jan 7, 2022

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jan 7, 2022

  • Use .json extension
  • Avoid seralizing entire LEGACY_SETTINGS
  • Use indentation to make the file readable.
  • Refactor JS settings file reading to avoid duplication.

@sbc100
Cleanup serialization of settings JSON file. NFC
ae69fd0 
- Use .json extension
- Avoid seralizing entire LEGACY_SETTINGS
- Use indentation to make the file readable.
- Refactor JS settings file reading to avoid duplication.
@sbc100 sbc100 requested a review from kripken January 7, 2022 16:07
@sbc100 sbc100 merged commit c365d36 into main Jan 7, 2022
@sbc100 sbc100 deleted the cleanup_settings_serialize branch January 7, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken